Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable updateRestateDependency task on CI #251

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion services/node-services/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ tasks.register<Copy>("prepareDockerBuild") {

if (!System.getenv("SDK_TYPESCRIPT_LOCAL_BUILD").isNullOrEmpty()) {
dependsOn("installLocalSdkTypescript")
} else {
} else if (System.getenv("CI").isNullOrEmpty()) {
// On CI we don't need to update the restate dependency, this is done implicitly by the e2e
// workflow.
dependsOn("updateRestateDependency")
Comment on lines +33 to 35
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I would like to understand is how does updating the restate-sdk dependency lead to a problem after a fresh install?

}

Expand Down
Loading