Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rewatch sources and build rewatch in CI #6762

Merged
merged 2 commits into from
May 25, 2024

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented May 23, 2024

First step of #6760.

  • Add rewatch sources
  • Build rewatch binaries for the different platforms in CI
  • Add rewatch binaries to npm package + a rewatch wrapper script that invokes the correct executable platform. (Eventually this should be integrated into the main rescript cli, or rewatch should replace the main rescript cli.)

@cknitt cknitt force-pushed the rewatch branch 13 times, most recently from c54f8b5 to ffff653 Compare May 24, 2024 13:18
@cknitt cknitt force-pushed the rewatch branch 2 times, most recently from bf7b048 to 5200a80 Compare May 25, 2024 13:17
@cknitt cknitt marked this pull request as ready for review May 25, 2024 13:48
@cknitt cknitt requested a review from cristianoc May 25, 2024 13:49
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe extend the clean command too, if it's possible for rewatch to need cleaning in order to unblock the build.

@cknitt cknitt merged commit f56f5c2 into rescript-lang:master May 25, 2024
19 checks passed
@cknitt cknitt deleted the rewatch branch May 25, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants