RFC: Typesafe "heterogenous" dependency arrays for React hooks #6502
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently the following issues with dependency arrays for React hooks, for example
useEffect
which is defined as follows:'deps
is actually an array or a tuple.(a, b)
to one, it is easy to just deleteb
and end up with(a)
instead of[a]
which is incorrect and can lead to issues at runtime.Idea:
dependency
.array<dependency>
.In this usage (invocation of React.useEffect/useCallback etc. with an array or tuple as the second parameter), the JSX PPX would e.g. convert
[a, b, c]
toJsxPPXReactSupport.unsafeToDependencyArray((a, b, c))
(with zero cost).This PR is a proof of concept for this idea.