Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow toggling panels in welcome screen app #6406

Merged
merged 1 commit into from
May 22, 2024
Merged

Allow toggling panels in welcome screen app #6406

merged 1 commit into from
May 22, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented May 22, 2024 •
edited

What

Mixed static and non-static data prevented edits from taking effect.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jleibs jleibs added 📺 re_viewer affects re_viewer itself 🟦 blueprint The data that defines our UI exclude from changelog PRs with this won't show up in CHANGELOG.md labels May 22, 2024
@jleibs jleibs marked this pull request as ready for review May 22, 2024 15:36
emilk
emilk approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@emilk emilk changed the title Don't use static timepoint for the welcome screen panel state Allow toggling panels in welcome screen app May 22, 2024
@emilk emilk merged commit 5befb57 into main May 22, 2024
38 of 39 checks passed
@emilk emilk deleted the jleibs/blueprint_panels branch May 22, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
🟦 blueprint The data that defines our UI exclude from changelog PRs with this won't show up in CHANGELOG.md 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't toggle panels on welcome screen
2 participants
@jleibs @emilk