Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic view property building, applied to TimeSeriesView's PlotLegend #6400

Merged
merged 11 commits into from
May 22, 2024
Merged

Generic view property building, applied to TimeSeriesView's PlotLegend #6400

merged 11 commits into from
May 22, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented May 21, 2024 •
edited by github-actions bot

What

What's happening:

  • edit uis for:
    • corner2d
    • visible
  • introduce generic method for drawing ui for a view property

Next steps in this area:

  • improve edit ui overall
    • make it easier to implement (with less boilerplate)
    • make default providing easier & more powerful (as described in passing there)
  • do this for more/all properties

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 🚜 refactor Change the code, not the functionality include in changelog labels May 21, 2024
@abey79 abey79 self-requested a review May 22, 2024 10:11
abey79
abey79 approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

crates/re_data_ui/src/editors/corner2d.rs Outdated Show resolved Hide resolved
crates/re_space_view_time_series/src/space_view_class.rs Outdated
.interactive(false)
.show_flat(
ui,
// TODO(andreas): Note that we loose the archetype's field name here, instead we label the item with the component name.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhat related, we'd need to route some textual information to hover tooltips.

@Wumpf Wumpf merged commit c49f480 into main May 22, 2024
34 checks passed
@Wumpf Wumpf deleted the andreas/generic-view-property-ui-for-timeseries branch May 22, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abey79 abey79 abey79 approved these changes

Assignees
No one assigned
Labels
include in changelog 🚜 refactor Change the code, not the functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Wumpf @abey79