Make visual time range on views a view property that can be set from python code #6164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… resolved visual range directly on DataResult. TODO: properly populate the new DataResult field and use it everywhere
Wumpf
added
🐍 Python API
Deployed docs
|
emilk
approved these changes
Apr 30, 2024
Comment on lines
95
to
96
| from: time_range_boundary_to_visible_history_boundary(&time_range.start), | ||
| to: time_range_boundary_to_visible_history_boundary(&time_range.end), |
There was a problem hiding this comment.
Not new in this PR, but this would read much better (and more idiomatic) as
Suggested change
| from: time_range_boundary_to_visible_history_boundary(&time_range.start), | |
| to: time_range_boundary_to_visible_history_boundary(&time_range.end), | |
| from: VisibleHistoryBoundary::from(&time_range.start), | |
| to: VisibleHistoryBoundary::from(&time_range.end), |
There was a problem hiding this comment.
but I really want to kill these conversions, not make them nicer 😄
There was a problem hiding this comment.
did the from'ification on the function name but didn't implement the trait now because I don't want the conversion disease to spread (would need to go to a different module)
5 tasks
jleibs
pushed a commit
that referenced
this pull request
May 2, 2024
…ntityProperties`) (#6190) ### What * Fixes #6175 This regressed in #6164. Decided not to roll back things (which would have been hard) but instead reimplement how these properties are passed through and make their role more obvious. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6190?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6190?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/6190) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`. --------- Co-authored-by: Clement Rey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
And some related refactors that I got engulfed with on this quest:
EntityPropertiesDataResultformation by dropping overrides from theOverrideContextEntityPropertiesaslegacy_propertiesin a lot of places which makes it easier to read these changesQueryRangetypePython API not great yet, will improve and provide examples in an upcoming iteration.
Planned direct follow-ups to this PR:
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerTo run all checks from
main, comment on the PR with@rerun-bot full-check.