Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codegen more of our Python arrow serialization #6154

Merged
merged 2 commits into from Apr 29, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Apr 29, 2024

What

This implements codegen of python arrow serialization in cases where we can just delegate to our datatypes.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added the do-not-merge Do not merge this PR label Apr 29, 2024
Base automatically changed from emilk/visual-2d-bounds to main April 29, 2024 15:15
@emilk emilk force-pushed the emilk/codegen-some-arrow-serialization branch 3 times, most recently from 5834ec7 to a41029a Compare April 29, 2024 17:53
@emilk emilk added 🐍 Python API Python logging API codegen/idl exclude from changelog PRs with this won't show up in CHANGELOG.md and removed do-not-merge Do not merge this PR labels Apr 29, 2024
@emilk emilk force-pushed the emilk/codegen-some-arrow-serialization branch from a41029a to af52c4b Compare April 29, 2024 18:08
@emilk emilk marked this pull request as ready for review April 29, 2024 18:19
Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable.

@Wumpf
Copy link
Member

Wumpf commented Apr 29, 2024

Jeremy says this is ok and I'm in need for some serialization, so chances this helps me. Merging :)

@Wumpf Wumpf merged commit 8760aa9 into main Apr 29, 2024
34 checks passed
@Wumpf Wumpf deleted the emilk/codegen-some-arrow-serialization branch April 29, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codegen/idl exclude from changelog PRs with this won't show up in CHANGELOG.md 🐍 Python API Python logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants