New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set visual 2D bounds from code #6127
Merged
Merged
Changes from 19 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
8f58dcf
Add .fbs definitions for visual bounds and AABB2D
emilk 85f8b27
Move VisualBounds to the blueprint store
emilk 1a28645
Add constructors for Python, that don't work
emilk 1d80315
Remove the _xy suffix
emilk d0b4777
Make the example work with _RERUN_TEST_FORCE_SAVE
emilk 3df5b97
fix up aabb2d python serialization
Wumpf 39c78b7
WIP: attempt fixing warning
Wumpf f498722
Sort and de-duplicated the "Use by" list in our docs
emilk 9ab4840
Remove unnecessary casts
emilk c317d5c
Remove promise about viewport linking
emilk be4ad4b
Better comments
emilk ce59b4a
Fix: Treat an empty component list as a `None` value without warning
emilk 14c8f6a
Reset snippet
emilk 816d542
Reset visible bounds to what's in the default blueprint
emilk 3c7f630
Add `VisualBounds` to snippets where it makes sense
emilk f1cdd53
Make the C++ and Rust snippets match the Python version
emilk 0d86e08
Add missing `default_bliueprint` to tests
emilk 4795eb7
codegen
emilk f6b89f3
Remove reference to deleted thing
emilk ac3a440
`vector` -> `aabb`
emilk File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
44 changes: 44 additions & 0 deletions
44
crates/re_query/src/latest_at/to_archetype/visual_bounds.rs
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah so the warning we saw was simply a bug