Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of old is_official_example machinery #5415

Closed
wants to merge 1 commit into from

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Mar 6, 2024

It conflicts with the new prefix-based way of doing things, leading to hashing stuff that shouldn't be hashed.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@teh-cmc teh-cmc added 🪳 bug Something isn't working 📊 analytics telemetry analytics exclude from changelog PRs with this won't show up in CHANGELOG.md labels Mar 6, 2024
@teh-cmc teh-cmc added the do-not-merge Do not merge this PR label Mar 6, 2024
@emilk
Copy link
Member

emilk commented Apr 9, 2024

Why is this marked as do-no-merge?

@teh-cmc
Copy link
Member Author

teh-cmc commented Apr 10, 2024

Why is this marked as do-no-merge?

There are still tradeoffs to be decided upon, see https://rerunio.slack.com/archives/C033K5VS2KD/p1709741044889959

@teh-cmc teh-cmc marked this pull request as draft April 10, 2024 07:02
@teh-cmc
Copy link
Member Author

teh-cmc commented May 2, 2024

It's just rotting at this point -- closing

@teh-cmc teh-cmc closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📊 analytics telemetry analytics 🪳 bug Something isn't working do-not-merge Do not merge this PR exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants