Zero-lengthed visible time ranges shouldn't silently fall back to latest-at #6135
Assignees
Labels
🪳 bug
Something isn't working
🔩 data model
ui
concerns graphical user interface
user-request
This is a pressing issue for one of our users
Comments
teh-cmc
added
🪳 bug
5 tasks
Wumpf
added a commit
that referenced
this issue
Apr 30, 2024
…python code (#6164) ### What * Part of [#6083](#6083) And _some_ related refactors that I got engulfed with on this quest: * document fate of remaining `EntityProperties` * simplify `DataResult` formation by dropping overrides from the `OverrideContext` * took the opportunity to call out `EntityProperties` as `legacy_properties` in a lot of places which makes it easier to read these changes * make it explicit when we want to use latest-at query by introducing `QueryRange` type Python API not great yet, will improve and provide examples in an upcoming iteration. Planned direct follow-ups to this PR: * finally remove old History types that we still convert to * should fix the rest of #6135 if it isn't already by this PR * make python interface actually nice * add examples & more docs ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6164?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6164?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/6164) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
5 tasks
Wumpf
added a commit
that referenced
this issue
Apr 30, 2024
### What * Fixes #6135 plus (and that's the bigger part of this PR) refactor time range handling to remove old `VisibleHistory` rust types. Commit by commit review recommended. Still need to fix the ui to better communicate when latest-at is used. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6172?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6172?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/6172) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Title.
I don't think it should fall back at all, but if it must then at the very least is needs a big fat warning.
The text was updated successfully, but these errors were encountered: