Skip to content

Commit

Permalink
Fix: docs-latest push workflow not triggered by release (#6366)
Browse files Browse the repository at this point in the history
### What

`release.yml` contains a bit of code that force-pushes the release
branch into `docs-latest`, which should then trigger a redeploy of
`rerun.io` together with updated env vars, e.g. `RELEASE_VERSION` set to
the newly released version. That did not happen because the default
`GITHUB_TOKEN` generated by GHA _cannot_ be used to trigger other
workflows:
https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#triggering-a-workflow-from-a-workflow

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6366?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6366?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6366)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.

---------

Co-authored-by: Andreas Reich <[email protected]>
  • Loading branch information
jprochazk and Wumpf committed May 21, 2024
1 parent 2b905fa commit ce3bda3
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,10 @@ jobs:
with:
fetch-depth: 0
ref: ${{ needs.version.outputs.release-commit }}
# `secrets.GITHUB_TOKEN` is used here so that the `git push … doc-latest`
# below can trigger a workflow run of the `on_push_docs.yml` workflow
# https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#triggering-a-workflow-from-a-workflow
token: ${{ secrets.GITHUB_TOKEN }}

- name: Update latest branch
run: |
Expand Down

0 comments on commit ce3bda3

Please sign in to comment.