fix: apply sync node listeners only after auth handler has been attached #1716
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firebase sdk handles all steps synchronously.
Hence, since the sync node listeners get applied before the authHandler callback is applied (effectively a race condition), the rdb interractions inside the authHandler take slightly longer time.
This time increases with increase in the size of the rule payload being fetched from the DB.
These changes add a global state about if the authHandler has been applied. Sync node listeners are attached only after they have been applied.
Although this state is redundant to the already present
initializations.auth
state, but wanted to keep this separate.