Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENGG-1789] fix: batch mv3 migration #1711

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

wrongsahil
Copy link
Member

Closes issue:

πŸ“œ Summary of changes:

βœ… Checklist:

  • Make sure linting and unit tests pass.
  • No install/build warnings introduced.
  • Verified UI in browser.
  • For UI changes, added/updated analytics events (if applicable).
  • For changes in extension's code, manually tested in Chrome and Firefox.
  • For changes in extension's code, both MV2 and MV3 are covered.
  • Added/updated unit tests for this change.
  • Raised pull request to update corresponding documentation (if already exists).

πŸ§ͺ Test instructions:

πŸ”— Other references:

Copy link

deepsource-io bot commented May 20, 2024

Here's the code health analysis summary for commits ae32108..05ad368. View details on DeepSourceΒ β†—.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Shell LogoShellβœ…Β SuccessView CheckΒ β†—
DeepSource JavaScript LogoJavaScript❌ Failure
❗ 3 occurences introduced
🎯 3 occurences resolved
View CheckΒ β†—

πŸ’‘ If you’re a repository administrator, you can configure the quality gates from the settings.

@wrongsahil wrongsahil merged commit 6d33fa8 into master May 23, 2024
2 of 3 checks passed
@wrongsahil wrongsahil deleted the batching-mv3-migrations branch May 23, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants