bump to nix:2.11.0, use full name for images #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Oct 7, 2022
| ARG GOLANG_IMAGE=golang:1.17.5-alpine@sha256:4918412049183afe42f1ecaf8f5c2a88917c2eab153ce5ecf4bf2d55c1507b74 | ||
| ARG NIX_IMAGE=nixos/nix:2.6.0@sha256:f085a81ca39642a405b41f45e8c21a369d89c65ca9f05d3a9b78dc5852d300ff | ||
| ARG GOLANG_IMAGE=docker.io/golang:1.17.5-alpine@sha256:4918412049183afe42f1ecaf8f5c2a88917c2eab153ce5ecf4bf2d55c1507b74 | ||
| ARG NIX_IMAGE=docker.io/nixos/nix:2.11.0@sha256:ef91f7bb5ef25d95b8a0437ce0ee5d1de5cfdf8ac882f1597f785068ea1e28af |
There was a problem hiding this comment.
Any reason to use full name?
There was a problem hiding this comment.
some systems don't assume docker.io as default
There was a problem hiding this comment.
Out of curiosity, what systems? It seems to me that at this point the ship has sailed and refs like this should be interpreted as docker.io for any system to be compatible with the world. As awkward as it is to couple tooling to particular hosts.
|
In Podman and in general stuff in the redhat ecosystem
…On Sun, Apr 2, 2023, 4:47 PM Alex Suraci ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In bootstrap.Dockerfile
<#15 (comment)>
:
> @@ -1,5 +1,5 @@
-ARG ***@***.***:4918412049183afe42f1ecaf8f5c2a88917c2eab153ce5ecf4bf2d55c1507b74
-ARG ***@***.***:f085a81ca39642a405b41f45e8c21a369d89c65ca9f05d3a9b78dc5852d300ff
+ARG ***@***.***:4918412049183afe42f1ecaf8f5c2a88917c2eab153ce5ecf4bf2d55c1507b74
+ARG ***@***.***:ef91f7bb5ef25d95b8a0437ce0ee5d1de5cfdf8ac882f1597f785068ea1e28af
Out of curiosity, what systems? It seems to me that at this point the ship
has sailed and refs like this should be interpreted as docker.io for any
system to be compatible with the world. As awkward as it is to couple
tooling to particular hosts.
—
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJS2V45ZTF6HXCF355VDFYTW7IF25ANCNFSM6AAAAAAQAV4ARU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
Irrelevant to this repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: LizeLive