Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2222] Fix Checkboxes Line Count #2223

Merged
merged 1 commit into from
May 18, 2024
Merged

[#2222] Fix Checkboxes Line Count #2223

merged 1 commit into from
May 18, 2024

Conversation

sopa301
Copy link
Contributor

@sopa301 sopa301 commented May 18, 2024

Fixes #2222

Proposed commit message

Fix Checkboxes Line Count

In c-file-type-checkboxes, the method getLabel() should show fileType,
lineCount and effective line count, but it currently shows fileType,
blankLineCount and effective line count instead.

Let's fix the code to show the correct counts.

Other information

ckcherry23
ckcherry23 approved these changes May 18, 2024
View reviewed changes
Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@ckcherry23 ckcherry23 merged commit 7d7a5a9 into reposense:master May 18, 2024
8 checks passed
@github-actions GitHub Actions
Copy link
Contributor

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckcherry23 ckcherry23 ckcherry23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checkboxes showing the wrong line counts
2 participants
@sopa301 @ckcherry23