Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow CI to pass if Codecov fails #2189

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Allow CI to pass if Codecov fails #2189

merged 2 commits into from
Apr 15, 2024

Conversation

asdfghjkxd
Copy link
Contributor

@asdfghjkxd asdfghjkxd commented Apr 15, 2024 •
edited by ckcherry23
Loading

Proposed commit message

CI is failing when Codecov is failing.

This is a temporary workaround for CI until issues with Codecov are
fixed.

Other information

@ckcherry23 ckcherry23 changed the title Update CI file Allow CI to pass if Codecov fails Apr 15, 2024
ckcherry23
ckcherry23 approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ckcherry23 ckcherry23 requested review from a team April 15, 2024 05:27
sopa301
sopa301 approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@sopa301 sopa301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ckcherry23 ckcherry23 merged commit 54d0028 into reposense:master Apr 15, 2024
8 checks passed
@github-actions GitHub Actions
Copy link
Contributor

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvidday vvidday vvidday approved these changes

@ckcherry23 ckcherry23 ckcherry23 approved these changes

@sopa301 sopa301 sopa301 approved these changes

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@asdfghjkxd @vvidday @ckcherry23 @sopa301