Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bin/ to .gitignore #2179

Merged
merged 6 commits into from
Apr 18, 2024
Merged

Add bin/ to .gitignore #2179

merged 6 commits into from
Apr 18, 2024

Conversation

jonasongg
Copy link
Contributor

Fixes #2169

Proposed commit message

Add bin/ to .gitignore

Currently, the bin/ folder generates files that are not in .gitignore
which produces a lot of untracked changes that can be annoying to
developers.

Let's add bin/ to .gitignore to prevent this issue.

Other information

@jonasongg jonasongg requested a review from a team March 30, 2024 06:50
sopa301
sopa301 approved these changes Mar 30, 2024
View reviewed changes
Copy link
Contributor

@sopa301 sopa301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sopa301 sopa301 requested a review from a team March 30, 2024 18:55
vvidday
vvidday approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@vvidday vvidday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although can we move the unrelated linting changes to another PR?

docs/_markbind/layouts/ug-sitenav.md Outdated Show resolved Hide resolved
ckcherry23
ckcherry23 approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ckcherry23 ckcherry23 merged commit bbb73a7 into reposense:master Apr 18, 2024
8 checks passed
@github-actions GitHub Actions
Copy link
Contributor

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvidday vvidday vvidday approved these changes

@ckcherry23 ckcherry23 ckcherry23 approved these changes

@sopa301 sopa301 sopa301 approved these changes

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add bin/ to .gitignore
4 participants
@jonasongg @vvidday @ckcherry23 @sopa301