[#2109] Add search by tag functionality #2167
Conversation
…into add-search-by-tag
There was a problem hiding this comment.
LGTM! I realised that the bug may be caused by my comment in the original PR suggesting to move the full.push(res) statement block out of the if-else statement (oops).
I think the getFilteredRepos method should probably be refactored sometime soon though, since there are some lines going up to 5(!) levels of indentation. In another PR maybe?
There was a problem hiding this comment.
Thanks @jonasongg - can I confirm that we can't add a test for the bug in #2164 due to our testing report only containing one group?
@sopa301 Great point, I agree that it could be refactored to increase readability - feel free to file an issue for this! |
There was a problem hiding this comment.
LGTM, thanks for fixing the bug @jonasongg!
Regarding the regression, I think we can file a new issue to add more repos to our Cypress setup and implement tests so that this doesn't happen again.
|
@vvidday Sorry for the late response, but yes, it's because our testing config contains only one repo. I will be creating an issue to add more repos soon! |
|
The following links are for previewing this pull request:
|
* [#2120] Update RepoSense contributors in documentation (#2138) The current About page on the RepoSense docs does not reflect the updated list of developers working on RepoSense. Let's move to update the list to more accurately reference the current developers of RepoSense. * [#2001] Extract c-zoom-commit-message component from views/c-zoom (#2132) Many of the frontend files are difficult to navigate through due to the large file sizes. As we add more features to the frontend, it is getting harder to maintain. This is also very unfriendly towards new contributors. Let us break down frontend files in a logical manner, continuing with extracting c-zoom-commit-message from views/c-zoom. * [#2142] Fix Vulnerabilities (#2143) Fix vulnerabilities in codebase. There are existing vulnerabilities in the codebase. Let's fix as many as possible. * Bump follow-redirects from 1.15.4 to 1.15.6 in /frontend (#2160) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.4...v1.15.6) * Bump webpack-dev-middleware from 5.3.3 to 5.3.4 in /frontend (#2168) Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) from 5.3.3 to 5.3.4. - [Release notes](https://github.com/webpack/webpack-dev-middleware/releases) - [Changelog](https://github.com/webpack/webpack-dev-middleware/blob/v5.3.4/CHANGELOG.md) - [Commits](webpack/webpack-dev-middleware@v5.3.3...v5.3.4) * [#2151] Update LoadingOverlay and Minor Versions of Node Dependencies (#2152) Update LoadingOverlay and Minor Versions of Node Dependencies Some dependencies are not at their latest minor or patch releases. Let's update these dependencies, as well as LoadingOverlay as part of a bug fix. * Factor out markdown parser * [#2109] Add search by tag functionality (#2167) Add search by tag functionality It can be useful to search author/repos by git tags. Let's add this functionality to make it easier to filter by tags. This commit also fixes a bug that existed in a previous version of the feature which resulted in all users being shown to belong to same group. * Refactor chunks * Fix style * Add parts of blurb * Fix linting * Fix style * Fix missing html parsing * Remove unused import --------- Co-authored-by: George Tay <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: jonasongg <[email protected]>
Fixes #2109
Proposed commit message
Other information