-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2158] Add More Documentation for Title Component #2159
Conversation
…into 2158-title-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The following links are for previewing this pull request:
|
@sopa301 Does this mean all dashboard will have a default title.md? That shouldn't be the case, as that will force users to override the title.md, turning this opt-in feature into an opt-out feature. |
Yes prof, I'll create a PR to remove it. If we still want the preview dashboard to have the title, I think we might need to create a separate config for the preview dashboard. I think other opt-in features (e.g. blurbs) will also be able to be featured via this arrangement. |
Fixes #2158.
Proposed commit message
Other information
Since the preview deployment uses the default build of the RepoSense report, all future builds will use the title component by default.