Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2151] Update CSS-related Major Dependencies #2154

Merged
merged 14 commits into from
Apr 18, 2024
Merged

[#2151] Update CSS-related Major Dependencies #2154

merged 14 commits into from
Apr 18, 2024

Conversation

sopa301
Copy link
Contributor

@sopa301 sopa301 commented Mar 11, 2024 •
edited
Loading

Part of #2151.

Proposed commit message

Update CSS-related Major Dependencies

A few CSS-related dependencies have major updates available.

Let's update as many as possible.

Other information

highlight.js has version 11 available, but I've avoided updating it because of breaking changes concerning unescaped HTML that the current (outdated) Pug loader cannot fix easily. Fortunately, there is a replacement @webdiscus/pug-loader that can both replace the deprecated pug-plain-loader and (in the future) implement Pug-friendly highlight.js without the need for an external library.

@sopa301 sopa301 marked this pull request as ready for review March 28, 2024 14:28
@sopa301 sopa301 requested a review from a team March 28, 2024 14:31
@sopa301 sopa301 mentioned this pull request Apr 5, 2024
Merged
jonasongg
jonasongg approved these changes Apr 6, 2024
View reviewed changes
Copy link
Contributor

@jonasongg jonasongg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonasongg jonasongg requested a review from a team April 6, 2024 13:36
ckcherry23
ckcherry23 reviewed Apr 13, 2024
View reviewed changes
frontend/package.json Outdated Show resolved Hide resolved
@sopa301 sopa301 requested a review from ckcherry23 April 13, 2024 08:06
ckcherry23
ckcherry23 approved these changes Apr 13, 2024
View reviewed changes
Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ckcherry23 ckcherry23 requested a review from a team April 13, 2024 09:36
MarcusTXK
MarcusTXK approved these changes Apr 13, 2024
View reviewed changes
Copy link
Member

@MarcusTXK MarcusTXK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ckcherry23
Copy link
Member

Hi @sopa301, can you please help resolve the merge conflicts so that we can merge this?

@sopa301
Copy link
Contributor Author

sopa301 commented Apr 18, 2024

Done!

@ckcherry23 ckcherry23 merged commit 6ffb41c into reposense:master Apr 18, 2024
8 checks passed
@github-actions GitHub Actions
Copy link
Contributor

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcusTXK MarcusTXK MarcusTXK approved these changes

@ckcherry23 ckcherry23 ckcherry23 approved these changes

@jonasongg jonasongg jonasongg approved these changes

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sopa301 @ckcherry23 @MarcusTXK @jonasongg