Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2120] Update RepoSense contributors in documentation #2138

Merged
merged 9 commits into from
Mar 27, 2024

Conversation

asdfghjkxd
Copy link
Contributor

Fixes #2120

Proposed commit message

The current About page on the RepoSense docs does not reflect the
updated list of developers working on RepoSense.

Let's move to update the list to more accurately reference the current
developers of RepoSense.

Other information

I'm not too sure what the start dates for everyone's contributions, so please do update me if I got it wrong!

@asdfghjkxd asdfghjkxd requested review from ckcherry23 and a team February 23, 2024 05:05
**Role**: Contributor [2022 January - ]<br/>

<!-- ------------------------------------------------------------------------------------------------------ -->

### [Zhou Jiahao](https://github.com/zhoukerrr)
### [Charisma Kausar](https://www.github.com/ckcherry23)
**Role**: Contributor [2024 January - ]<br/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Role**: Contributor [2024 January - ]<br/>
**Role**: Committer [2024 January - ]<br/>
Contributor [2022 December - ]<br/>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be safe to assume that all current mentors have the same title? (except for maybe @gok99 who was already on the list?)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should have the same title. Even @gok99 would be a Committer now. But his contributor start date should be a year earlier.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, I have updated the commit now, it should reflect the correct roles and start dates now!

docs/about.md Outdated
<!-- ------------------------------------------------------------------------------------------------------ -->

### [Alvis Ng](https://www.github.com/supermii2)
**Role**: Developer [2024 January - ]<br/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 'Contributor' instead of 'Developer'

Suggested change
**Role**: Developer [2024 January - ]<br/>
**Role**: Contributor [2024 January - ]<br/>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it! Will update and commit!

@ckcherry23 ckcherry23 requested a review from a team February 23, 2024 07:48
docs/about.md Outdated
<!-- ------------------------------------------------------------------------------------------------------ -->

### [Marcus Tang Xin Kye](https://www.github.com/MarcusTXK)
**Role**: Comitter [2024 January - ]<br/>
Copy link
Contributor

@jonasongg jonasongg Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be a typo here! otherwise LGTM!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh oops missed out a m, will fix!

Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @asdfghjkxd, based on the data we have for now, I have left 2 comments to look into.

docs/about.md Outdated
<!-- ------------------------------------------------------------------------------------------------------ -->

### [David Gareth Ong](https://www.github.com/vvidday)
**Role**: Committer [2024 January - ]<br/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All mentors were contributors too! (So update for David and Marcus)

Suggested change
**Role**: Committer [2024 January - ]<br/>
**Role**: Committer [2024 January - ]<br/>
Contributor [2023 January - ]<br/>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, will do!

docs/about.md Outdated
@@ -55,13 +55,50 @@ Contributor [2021 January - ]<br/>

<!-- ------------------------------------------------------------------------------------------------------ -->

### [Gokul Rajiv](https://github.com/gok99)
### [Zhou Jiahao](https://github.com/zhoukerrr)
**Role**: Contributor [2022 January - ]<br/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add "Committer [2023 January - ]" for Zhou Jiahao, Chan Jun Da, Tay Yi Hsuen

Suggested change
**Role**: Contributor [2022 January - ]<br/>
**Role**: Committer [2023 January - ]<br/>
Contributor [2022 January - ]<br/>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing!

docs/about.md Outdated

<!-- ------------------------------------------------------------------------------------------------------ -->

### [Gokul Rajiv](https://github.com/gok99)
**Role**: Contributor [2022 January - ]<br/>
**Role**: Committer [2024 January - ]<br/>
Contributor [2021 January - ]<br/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 2022 January (same as Jiahao)

Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @asdfghjkxd, Can I trouble you to make some more updates to the contributors list?

  1. We got information from prof about some members and their roles:
Wang Chao
Role: Project Lead [2021 Jan - 2021 Dec]
Maintainer [2020 May - 2021 Jan]
 
Hsu Zhong Jun
Role: Project Lead [2022 Jan - 2022 Dec]
Committer [2021 June - 2021 Dec]
 
Chan Ger Hean
Role: Committer [2022 Jan - 2022 Dec]
 
Huang Chengyu
Role: Project Co-Lead [2023 Jan - 2023 Apr]
Senior Dev [2023 Jan - 2023 Apr]
Committer [2022 Jan - 2022 Dec]
Contributor [2021 July - 2021 Dec]
 
Chan Jun Da
Role: Project Co-Lead [2023 Apr- 2023 Dec]
Senior Dev [2023 Jan - 2023 Apr]
Committer [2022 Jan - 2022 Dec]
Contributor [2021 July - 2021 Dec]
 
Tay Yi Hsuen
Role: Senior Dev [2023 Jan - 2023 Apr]
Committer [2022 Jan - 2022 Dec]
Contributor [2021 July - 2021 Dec]
 
Zhou Jiahao
Role: Senior Dev [2023 Jan - 2023 Apr]
Committer [2022 Jan - 2022 Dec]
Contributor [2021 July - 2021 Dec]
  1. All the above can be moved to the 'Past Members' section.

  2. The 4 mentors (Me, David, Marcus, and Gokul), list our current role as 'Senior Developer' for now.

  3. Also, please change the end dates of the 'Contributor' role for us 4 mentors so that they end when the 'Senior Developer' role starts.

  4. Please add the following person to the current team section.

Chang Si Kai
Role: Contributor [2023 Jan - ]

@asdfghjkxd
Copy link
Contributor Author

Hi @ckcherry23, I have made the necessary changes following the changes detailed in your previous comment. Please do let me know if I had missed anything out!

Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, looks good to me!

@ckcherry23 ckcherry23 requested a review from a team March 15, 2024 15:30
Copy link
Contributor

@gok99 gok99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ckcherry23 ckcherry23 merged commit a733531 into reposense:master Mar 27, 2024
10 checks passed
Copy link
Contributor

The following links are for previewing this pull request:

asdfghjkxd added a commit that referenced this pull request Apr 4, 2024
* [#2120] Update RepoSense contributors in documentation (#2138)

The current About page on the RepoSense docs does not reflect the
updated list of developers working on RepoSense.

Let's move to update the list to more accurately reference the current
developers of RepoSense.

* [#2001] Extract c-zoom-commit-message component from views/c-zoom (#2132)

Many of the frontend files are difficult to navigate through due to the
large file sizes. As we add more features to the frontend, it is
getting harder to maintain. This is also very unfriendly towards new
contributors. 

Let us break down frontend files in a logical manner, continuing with
extracting c-zoom-commit-message from views/c-zoom.

* [#2142] Fix Vulnerabilities (#2143)

Fix vulnerabilities in codebase.

There are existing vulnerabilities in the codebase.

Let's fix as many as possible.

* Bump follow-redirects from 1.15.4 to 1.15.6 in /frontend (#2160)

Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.15.4...v1.15.6)

* Bump webpack-dev-middleware from 5.3.3 to 5.3.4 in /frontend (#2168)

Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) from 5.3.3 to 5.3.4.
- [Release notes](https://github.com/webpack/webpack-dev-middleware/releases)
- [Changelog](https://github.com/webpack/webpack-dev-middleware/blob/v5.3.4/CHANGELOG.md)
- [Commits](webpack/webpack-dev-middleware@v5.3.3...v5.3.4)

* [#2151] Update LoadingOverlay and Minor Versions of Node Dependencies (#2152)

Update LoadingOverlay and Minor Versions of Node Dependencies

Some dependencies are not at their latest minor or patch releases.

Let's update these dependencies, as well as LoadingOverlay as part of a
bug fix.

* Factor out markdown parser

* [#2109] Add search by tag functionality (#2167)

Add search by tag functionality

It can be useful to search author/repos by git tags.

Let's add this functionality to make it easier to filter by tags. This
commit also fixes a bug that existed in a previous version of the
feature which resulted in all users being shown to belong to same group.

* Refactor chunks

* Fix style

* Add parts of blurb

* Fix linting

* Fix style

* Fix missing html parsing

* Remove unused import

---------

Co-authored-by: George Tay <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jonasongg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update RepoSense contributors in documentation
5 participants