-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2130] Add highlight and scroll to group #2131
Merged
ckcherry23
merged 24 commits into
reposense:master
from
jonasongg:add-highlight-scroll-to-group
Apr 18, 2024
Merged
Changes from 2 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
437f318
Add highlight and scroll to repo
jonasongg 9e8ce15
Fix indentation
jonasongg 541c484
Fix indentation again
jonasongg dc79133
Set highlighted fields to null if chart is not found
jonasongg c1d0ddb
Change highlight colour
jonasongg d039787
Merge remote-tracking branch 'upstream/master' into add-highlight-scr…
jonasongg b34c0bb
Change logic of highlighting repo
jonasongg cf9cc37
remove unused code
jonasongg 3ecb81a
remove unused highlighter icon
jonasongg 3312c75
fix lint error
jonasongg 2c06a41
clarify selectedChart id
jonasongg de0db3f
add cypress test for scroll to highlighted repo
jonasongg da74dd6
add retries to flaky scroll to test
jonasongg 8693bff
finetune the retry options for flaky scroll test
jonasongg cd57797
add scrollIntoView for initial click for scroll test
jonasongg b2a4126
Merge remote-tracking branch 'upstream/master' into add-highlight-scr…
jonasongg e901c4b
fix failing scroll test
jonasongg 3fb8773
Merge branch 'master' into add-highlight-scroll-to-group
ckcherry23 4aef6ee
Merge branch 'master' into add-highlight-scroll-to-group
jonasongg 7f0f742
remove smooth scrolling from highlight scroll to group
jonasongg 040a5b6
Merge remote-tracking branch 'refs/remotes/origin/add-highlight-scrol…
jonasongg 9b30a73
Merge branch 'master' into add-highlight-scroll-to-group
jonasongg c2328ae
Merge branch 'master' into add-highlight-scroll-to-group
ckcherry23 cd8c09a
Merge branch 'master' into add-highlight-scroll-to-group
jonasongg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is a bit strange (the need to calculate an offset) because of the way the refs are stored for summary-chart. Basically, there are multiple groups and in each group, multiple repos. But the number X in the ref for
summary-chart-X
refers to the index of the repo in the individual group. This means that in each ref, there is actually an array of div elements from multiple groups. I didn't want to change the way the refs were stored since the iframe feature seems to depend on it