[#2128] Fix Blurry Favicon #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sopa301
force-pushed
the
2128-blurry-favicon
branch
2 times, most recently
from
4697bc4
to
e1af162
Compare
sopa301
force-pushed
the
2128-blurry-favicon
branch
from
e1af162
to
e6bb786
Compare
ckcherry23
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Thanks for taking this up @sopa301!
Upon some research, it seems like various sources online have differing opinions on what size(s) of favicons should be used for websites.
- While the original size we used (16x16) is considered one of the standard sizes that should work well for most browsers, it seems like larger sizes such as the 200x200 we are using now can be scaled down correctly most of the time.
- Also, our MarkBind docs site uses the same 200x200
favicon.icofile as the site header.
Considering this, and that this will increase the clarity of the favicon, I think the larger .ico file should be okay.
MarcusTXK
approved these changes
Feb 23, 2024
|
The following links are for previewing this pull request:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2128
Proposed commit message
Other information
To view the new image, clear the cache.