Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2111] Fix failing zoomFeature cypress test #2114

Merged
merged 1 commit into from
Feb 16, 2024
Merged

[#2111] Fix failing zoomFeature cypress test #2114

merged 1 commit into from
Feb 16, 2024

Conversation

jonasongg
Copy link
Contributor

Fixes #2111
Fixes #2066 also

Proposed commit message

Fix nondeterministically failing zoomFeature cypress test

The "range changes in chartview should reflect in zoom" test in
chartView_zoomFeature.cy.js fails because as time passes, the
coordinates in the ramp that correspond to the desired zoom area
change.

Let's add an "until" filter to the relevant cypress tests to stop this
from happening

Other information

@jonasongg jonasongg requested a review from a team February 16, 2024 10:45
asdfghjkxd
asdfghjkxd approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@asdfghjkxd asdfghjkxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job on the investigation and fix for the failing test cases!

@jonasongg jonasongg requested a review from a team February 16, 2024 13:33
ckcherry23
ckcherry23 approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the prompt PR @jonasongg!

@ckcherry23 ckcherry23 requested a review from a team February 16, 2024 16:00
MarcusTXK
MarcusTXK approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@MarcusTXK MarcusTXK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job

@ckcherry23
Copy link
Member

Merging before the 2-day wait period to unblock other PRs.

@ckcherry23 ckcherry23 merged commit 9ff7a96 into reposense:master Feb 16, 2024
10 checks passed
@github-actions GitHub Actions
Copy link
Contributor

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcusTXK MarcusTXK MarcusTXK approved these changes

@ckcherry23 ckcherry23 ckcherry23 approved these changes

@asdfghjkxd asdfghjkxd asdfghjkxd approved these changes

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
4 participants
@jonasongg @ckcherry23 @MarcusTXK @asdfghjkxd