Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2112] Move Segment CSS into segment.vue #2113

Merged
merged 4 commits into from
Feb 19, 2024
Merged

[#2112] Move Segment CSS into segment.vue #2113

merged 4 commits into from
Feb 19, 2024

Conversation

sopa301
Copy link
Contributor

@sopa301 sopa301 commented Feb 16, 2024

Fixes #2112.

Proposed commit message

The segment component CSS currently resides in the c-authorship-file
component. Moving it to the segment component would make it easier to
edit the segment component in the future.

Lets move the CSS into segment.vue.

Other information

I've also decided to add the scoped attribute to the segment CSS style block since it's not being used anywhere else in the code base.

@sopa301 sopa301 marked this pull request as ready for review February 16, 2024 08:19
@sopa301 sopa301 requested a review from a team February 16, 2024 08:19
jonasongg
jonasongg approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@jonasongg jonasongg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ckcherry23 ckcherry23 requested a review from a team February 16, 2024 17:10
ckcherry23
ckcherry23 approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ckcherry23 ckcherry23 requested a review from a team February 16, 2024 18:48
vvidday
vvidday approved these changes Feb 17, 2024
View reviewed changes
Copy link
Contributor

@vvidday vvidday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonasongg jonasongg requested review from a team and removed request for a team February 17, 2024 06:28
@ckcherry23 ckcherry23 merged commit fdb1892 into reposense:master Feb 19, 2024
10 checks passed
@github-actions GitHub Actions
Copy link
Contributor

The following links are for previewing this pull request:

@ckcherry23
Copy link
Member

Merging this PR appears to have broken the code-highlighting feature. We need further investigation to see what caused the issue and it needs to be fixed as soon as possible.

@damithc
Copy link
Collaborator

damithc commented Feb 21, 2024

Also, whenever a regression happens, also look into if if a similar thing can be prevented in future, for example, by adding a test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvidday vvidday vvidday approved these changes

@ckcherry23 ckcherry23 ckcherry23 approved these changes

@jonasongg jonasongg jonasongg approved these changes

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move CSS for Segment component into c-segment.vue
5 participants
@sopa301 @ckcherry23 @damithc @vvidday @jonasongg