Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2103] Refactor parser package for greater organisation of classes #2104

Merged

Conversation

asdfghjkxd
Copy link
Contributor

Fixes #2103

Proposed commit message

Classes in the `parser` package as of now are not properly organised,
with exceptions, types and parser classes being found in the same
directory level.

This does not follow the convention established by other packages,
whereby logically similar classes are further grouped into
sub-packages.

Let's move to refactor the `parser` package to ensure that it follows
the overall structure of the other packages and to increase the level
of organisation within the `parser` package.

Other information

Some accidental commits from another branch have bled through into this branch, however, I have removed the offending code/comments and tried as best as I could to restore it back to the original state.

Copy link
Contributor

@sopa301 sopa301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@asdfghjkxd asdfghjkxd requested a review from a team January 30, 2024 08:16
Copy link
Contributor

@gok99 gok99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@gok99 gok99 requested a review from a team January 31, 2024 02:13
Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this refactor!

@ckcherry23 ckcherry23 merged commit 29903e3 into reposense:master Feb 6, 2024
10 checks passed
Copy link
Contributor

github-actions bot commented Feb 6, 2024

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor parser package for greater organisation of classes
4 participants