Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2003] Suppress Console Warning #2088

Merged
merged 2 commits into from
Jan 26, 2024
Merged

[#2003] Suppress Console Warning #2088

merged 2 commits into from
Jan 26, 2024

Conversation

sopa301
Copy link
Contributor

@sopa301 sopa301 commented Jan 21, 2024

Fixes #2003

Proposed commit message

Suppress unexpected console warning

A theoretically unreachable console.error() statement has raised a
warning from CI builds. Multiple warnings from this intentional
statement may cause an undesirable warning to be disregarded due to the
large warning count.

Let's suppress this particular warning.

Other information

@sopa301 sopa301 requested a review from a team January 21, 2024 08:23
asdfghjkxd
asdfghjkxd approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@asdfghjkxd asdfghjkxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it makes sense to suppress unnecessary linting warnings for code that executes only under very exceptional circumstances, making the true linting warnings or errors more prominent.

@sopa301 sopa301 requested a review from a team January 22, 2024 12:32
vvidday
vvidday approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@vvidday vvidday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ckcherry23 ckcherry23 merged commit c2ac8d1 into reposense:master Jan 26, 2024
10 checks passed
@github-actions GitHub Actions
Copy link
Contributor

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gok99 gok99 gok99 approved these changes

@vvidday vvidday vvidday approved these changes

@asdfghjkxd asdfghjkxd asdfghjkxd approved these changes

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suppress unexpected console statement warnings
5 participants
@sopa301 @gok99 @vvidday @asdfghjkxd @ckcherry23