[#2076] Refactor RepoConfiguration to simplify constructor complexity

src/main/java/reposense/model/CliRunConfiguration.java

@@ -31,7 +31,11 @@ public List<RepoConfiguration> getRepoConfigurations() throws ParseException {
  List<RepoConfiguration> configs = new ArrayList<>();
  for (String locationString : cliArguments.getLocations()) {
  try {
- configs.add(new RepoConfiguration(new RepoLocation(locationString)));
+ configs.add(
+ new RepoConfiguration.Builder()
+ .location(new RepoLocation(locationString))
+ .build()
+ );
  } catch (InvalidLocationException ile) {
  logger.log(Level.WARNING, ile.getMessage(), ile);
  }

src/main/java/reposense/parser/ConfigurationBuildException.java

@@ -0,0 +1,8 @@
+package reposense.parser;
+
+/**
+ * Signals that there was an issue building a Configuration (missing parameters, etc.).
+ */
+public class ConfigurationBuildException extends RuntimeException {
+
+}

src/main/java/reposense/parser/RepoConfigCsvParser.java

@@ -172,11 +172,25 @@ private void addConfig(List<RepoConfiguration> results, RepoLocation location, S
  boolean isIgnoredFileAnalysisSkipped, boolean isFileSizeLimitOverriding, long fileSizeLimit,
  boolean isStandaloneConfigIgnored, boolean isShallowCloningPerformed,
  boolean isFindingPreviousAuthorsPerformed) {
- RepoConfiguration config = new RepoConfiguration(location, branch, formats, ignoreGlobList, fileSizeLimit,
- isStandaloneConfigIgnored, isFileSizeLimitIgnored, ignoreCommitList, isFormatsOverriding,
- isIgnoreGlobListOverriding, isIgnoreCommitListOverriding, isFileSizeLimitOverriding,
- isShallowCloningPerformed, isFindingPreviousAuthorsPerformed, isIgnoredFileAnalysisSkipped,
- ignoredAuthorsList, isIgnoredAuthorsListOverriding);
+ RepoConfiguration config = new RepoConfiguration.Builder()
+ .location(location)
+ .branch(branch)
+ .fileTypeManager(formats)
+ .ignoreGlobList(ignoreGlobList)
+ .fileSizeLimit(fileSizeLimit)
+ .isStandaloneConfigIgnored(isStandaloneConfigIgnored)
+ .isFileSizeLimitIgnored(isFileSizeLimitIgnored)
+ .ignoreCommitList(ignoreCommitList)
+ .isFormatsOverriding(isFormatsOverriding)
+ .isIgnoreGlobListOverriding(isIgnoreGlobListOverriding)
+ .isIgnoreCommitListOverriding(isIgnoreCommitListOverriding)
+ .isFileSizeLimitOverriding(isFileSizeLimitOverriding)
+ .isShallowCloningPerformed(isShallowCloningPerformed)
+ .isFindingPreviousAuthorsPerformed(isFindingPreviousAuthorsPerformed)
+ .isIgnoredFileAnalysisSkipped(isIgnoredFileAnalysisSkipped)
+ .ignoredAuthorsList(ignoredAuthorsList)
+ .isIgnoredAuthorsListOverriding(isIgnoredAuthorsListOverriding)
+ .build();
 
  if (results.contains(config)) {
  logger.warning("Ignoring duplicated repository " + location + " " + branch);

src/systemtest/java/reposense/LocalRepoSystemTest.java

@@ -39,10 +39,18 @@ public class LocalRepoSystemTest {
 
  @BeforeAll
  public static void setupLocalRepos() throws Exception {
- TestRepoCloner.clone(new RepoConfiguration(new RepoLocation("https://github.com/reposense/testrepo-Alpha")),
- Paths.get("."), LOCAL_DIRECTORY_ONE);
- TestRepoCloner.clone(new RepoConfiguration(new RepoLocation("https://github.com/reposense/testrepo-Alpha")),
- Paths.get("."), LOCAL_DIRECTORY_TWO);
+ TestRepoCloner.clone(
+ new RepoConfiguration.Builder()
+ .location(new RepoLocation("https://github.com/reposense/testrepo-Alpha"))
+ .build(),
+ Paths.get("."), LOCAL_DIRECTORY_ONE
+ );
+ TestRepoCloner.clone(
+ new RepoConfiguration.Builder()
+ .location(new RepoLocation("https://github.com/reposense/testrepo-Alpha"))
+ .build(),
+ Paths.get("."), LOCAL_DIRECTORY_TWO
+ );
  }
 
  @BeforeEach

src/test/java/reposense/git/GitBranchTest.java

@@ -31,8 +31,10 @@ public void getCurrentBranch_masterBranch_success() throws Exception {
 
  @Test
  public void getCurrentBranch_uncommonDefaultBranch_success() throws Exception {
- RepoConfiguration uncommonDefaultConfig = new RepoConfiguration(
- new RepoLocation(TEST_REPO_UNCOMMON_DEFAULT_GIT_LOCATION), RepoConfiguration.DEFAULT_BRANCH);
+ RepoConfiguration uncommonDefaultConfig = new RepoConfiguration.Builder()
+ .location(new RepoLocation(TEST_REPO_UNCOMMON_DEFAULT_GIT_LOCATION))
+ .branch(RepoConfiguration.DEFAULT_BRANCH)
+ .build();
  uncommonDefaultConfig.setFormats(FileTypeTest.DEFAULT_TEST_FORMATS);
  TestRepoCloner.cloneAndBranch(uncommonDefaultConfig);
  String currentBranch = GitBranch.getCurrentBranch(uncommonDefaultConfig.getRepoRoot());