Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#944] Improve visualization for full and partial credit #2070

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
075d34d
[#2027] Fix date range bug (#2034)
jq1836 Sep 24, 2023
0c80ee6
[#2039] Update cypress minimum requirement to 12.15.0 (#2041)
chan-j-d Sep 30, 2023
46409aa
[#1936] Migrate c-segment.vue to typescript (#2035)
jq1836 Sep 30, 2023
43828fd
[#1936] Migrate load-font-awesome-icons.js to typescript (#2040)
jq1836 Sep 30, 2023
d4e2272
[#2045] Fix cypress zoom feature test (#2047)
jq1836 Oct 4, 2023
a8c3f00
[#1936] Migrate random-color-gen.js to typescript (#2043)
jq1836 Oct 4, 2023
93e850f
[#1936] Migrate c-segment-collection.vue to typescript (#2036)
jq1836 Oct 4, 2023
0d1cd99
[#1936] Migrate c-resizer.vue to typescript (#2038)
jq1836 Oct 4, 2023
6292688
Bump zod from 3.20.6 to 3.22.3 in /frontend (#2048)
dependabot[bot] Oct 4, 2023
7bc056a
Bump @cypress/request and cypress in /frontend/cypress (#2042)
dependabot[bot] Oct 4, 2023
0c4045d
[#1936] Migrate c-ramp.vue to typescript (#2037)
jq1836 Oct 11, 2023
174ecc5
Merge branch 'master' into 944-analyze-authorship
SkyBlaise99 Oct 20, 2023
e200e5e
Give partial credit if annotated author is not the same as the blame
SkyBlaise99 Oct 20, 2023
00cf40d
[#2054] Fix zoom view bug (#2055)
jq1836 Oct 28, 2023
4dae85d
[#1936] Migrate repo-sorter.js to typescript (#2052)
jq1836 Oct 28, 2023
7450425
[#1936] Migrate safari_date.js to typescript (#2053)
jq1836 Oct 28, 2023
056fa5f
Remove frontend JS lint (#2063)
jq1836 Oct 28, 2023
bdeb15a
use full and partial credit color
SkyBlaise99 Oct 29, 2023
54596ed
[#1929] Add dynamic positioning support for tooltips (#2056)
pratham31012002 Nov 7, 2023
a187d9c
Add test cases for annotated author overriding last author's credit
SkyBlaise99 Nov 7, 2023
58b7002
Merge branch 'master' into 944-analyze-authorship
SkyBlaise99 Nov 7, 2023
b296b83
revert merge from master
SkyBlaise99 Nov 7, 2023
4ce6545
revert merge from master 58b70025
SkyBlaise99 Nov 7, 2023
f29dc16
[#1928] Fix tooltip zIndex such that it doesn't occlude next file tit…
pratham31012002 Nov 8, 2023
e42c14e
[#1726] Update GitHub-specific references in codebase and docs (#2050)
chan-j-d Nov 8, 2023
4bd05a7
Trigger workflow
SkyBlaise99 Nov 8, 2023
950c912
Merge branch 'master' into 944-analyze-authorship
SkyBlaise99 Nov 8, 2023
a46d423
Revert "Merge branch 'master' into 944-analyze-authorship"
SkyBlaise99 Nov 8, 2023
bba556d
fix frontend test failing
SkyBlaise99 Nov 8, 2023
4d7d3aa
Merge branch '944-analyze-authorship' into 944-analyze-authorship
SkyBlaise99 Nov 12, 2023
1b25572
Merge branch '944-swap-color' into 944-analyze-authorship
SkyBlaise99 Nov 12, 2023
9e93961
Merge branch 'reposense:944-analyze-authorship' into 944-analyze-auth…
SkyBlaise99 Nov 12, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frontend/src/styles/_colors.scss
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,8 @@ $mui-colors: (
'github': (
'title-background': #FAFBFC,
'border': #E1E4E8,
'authored-code-background': #E6FFED,
'full-authored-code-background': #C8E6C9,
'partial-authored-code-background': #E6FFED,
),
'grey': (
'50': #FAFAFA,
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/views/c-authorship.vue
Original file line number Diff line number Diff line change
Expand Up @@ -984,7 +984,7 @@ export default defineComponent({
.segment {
border-left: .25rem solid mui-color('green');
.code {
background-color: mui-color('github', 'authored-code-background');
background-color: mui-color('github', 'full-authored-code-background');
padding-left: 1rem;
}
.line-number {
Expand All @@ -1009,7 +1009,7 @@ export default defineComponent({
}
&.isNotFullCredit {
.code {
background-color: mui-color('green', '100');
background-color: mui-color('github', 'partial-authored-code-background');
}
}
&.untouched {
Expand Down
Loading