Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1936] Migrate c-segment-collection.vue to typescript #2036

Merged
merged 7 commits into from
Oct 4, 2023
Merged

[#1936] Migrate c-segment-collection.vue to typescript #2036

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
400cfa4
Convert c-segment-collection to typescript
jq1836 Sep 13, 2023
fdce5b0
Fix unintended bug introduced
jq1836 Sep 13, 2023
aae845d
Merge branch 'master' into 1936-migrate-c-seg-col
chan-j-d Sep 24, 2023
78f462c
Merge branch 'master' into 1936-migrate-c-seg-col
chan-j-d Sep 30, 2023
e1f6bf6
Merge branch 'master' into 1936-migrate-c-seg-col
chan-j-d Sep 30, 2023
3906226
Merge branch 'master' into 1936-migrate-c-seg-col
chan-j-d Sep 30, 2023
2f6aa23
Merge branch 'master' into 1936-migrate-c-seg-col
chan-j-d Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions frontend/src/components/c-segment-collection.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,19 @@
c-segment(v-bind:segment="segment", v-bind:path="path")
</template>

<script>
<script lang='ts'>
import { defineComponent } from 'vue';
import cSegment from './c-segment.vue';
import Segment from '../utils/segment';

export default {
export default defineComponent({
name: 'c-segment-collection',
components: {
cSegment,
},
props: {
segments: {
type: Array,
type: Array<Segment>,
required: true,
},
path: {
Expand All @@ -28,11 +30,11 @@ export default {
};
},
methods: {
visibilityChanged(isVisible) {
visibilityChanged(isVisible: boolean) {
if (isVisible) {
this.isRendered = true;
}
},
},
};
});
</script>
Loading