Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1998] Fix hard to read text in dark labels #2029

Merged
merged 3 commits into from
Aug 20, 2023
Merged

[#1998] Fix hard to read text in dark labels #2029

merged 3 commits into from
Aug 20, 2023

Conversation

jq1836
Copy link
Contributor

@jq1836 jq1836 commented Aug 19, 2023 •
edited
Loading

Fixes #1998

Proposed commit message

Text in file type labels in the summary view are hard to read,
particularly when the label background is dark.

Let's make the text in the labels readable when the label
background is dark.

Other information

Details of the problem and the solution taken have been documented in issue #1998, however, in addition to the summary view, the commits and code panels also had the same issue, which is fixed in this PR.

Screenshots

Summary View

Before
image

After
image

Commits Panel

Before
image

After
image

Code Panel

Before
image

After
image

@jq1836 jq1836 changed the title Modify c-summary getFontColor method [#1998] Modify c-summary getFontColor method Aug 19, 2023
@jq1836 jq1836 changed the title [#1998] Modify c-summary getFontColor method [#1998] Fix hard to read text in dark labels Aug 19, 2023
@jq1836 jq1836 marked this pull request as draft August 19, 2023 06:27
@jq1836 jq1836 marked this pull request as ready for review August 19, 2023 06:53
ckcherry23
ckcherry23 approved these changes Aug 19, 2023
View reviewed changes
Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, LGTM!

@ckcherry23 ckcherry23 requested a review from a team August 19, 2023 15:48
vvidday
vvidday approved these changes Aug 20, 2023
View reviewed changes
Copy link
Contributor

@vvidday vvidday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chan-j-d chan-j-d merged commit 324a0cb into reposense:master Aug 20, 2023
10 checks passed
@github-actions
Copy link
Contributor

The following links are for previewing this pull request:

@jq1836 jq1836 deleted the 1998-fix-label-text-bug branch August 22, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvidday vvidday vvidday approved these changes

@ckcherry23 ckcherry23 ckcherry23 approved these changes

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hard to read label text for some dark label colors
4 participants
@jq1836 @vvidday @ckcherry23 @chan-j-d