Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1943] Make ErrorSummary non-static by removing singleton design pattern #2021

Closed
wants to merge 1 commit into from
Closed

[#1943] Make ErrorSummary non-static by removing singleton design pattern #2021

wants to merge 1 commit into from

Conversation

germainelee02
Copy link
Contributor

Fixes #1943

Currently, ErrorSummary implements the singleton design pattern.
However, ErrorSummary have to be made non-static if we 
want to parallelize/have concurrent runs of RepoSense.

Let's modify ErrorSummary to be non-static.

@germainelee02 germainelee02 marked this pull request as draft July 11, 2023 09:31
@germainelee02
Copy link
Contributor Author

Close PR after looking at this: #1947 (comment)

@github-actions
Copy link
Contributor

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
s.Ongoing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make ErrorSummary non-static by removing singleton design pattern
2 participants
@germainelee02 @ckcherry23