Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1940] Increasing Cypress Timeout Configuration #2020

Merged
merged 3 commits into from
Aug 2, 2023
Merged

[#1940] Increasing Cypress Timeout Configuration #2020

merged 3 commits into from
Aug 2, 2023

Conversation

germainelee02
Copy link
Contributor

@germainelee02 germainelee02 commented Jul 9, 2023 •
edited by chan-j-d
Loading

Fixes #1940

Currently the timeout to load pages is 18000. Hence, cypress 
is unable to start on some local machines as network request 
are limited to the underlying operating system, 
and can still timeout if the value is increased.

Let's increase the cypress timeout configuration.

@ckcherry23 ckcherry23 requested a review from a team July 11, 2023 11:18
@ckcherry23
Copy link
Member

Hi @zhoukerrr, can I check if a pageLoadTimeout of 200000 is sufficient to start Cypress on your local machine without a premature timeout?

@zhoukerrr
Copy link
Contributor

Hi @zhoukerrr, can I check if a pageLoadTimeout of 200000 is sufficient to start Cypress on your local machine without a premature timeout?

Doubling will be better.

@ckcherry23 ckcherry23 requested review from gok99 and a team July 24, 2023 04:23
chan-j-d
chan-j-d approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@chan-j-d chan-j-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @germainelee02 could you update the commit message to follow the maximum char limit 72 per line.

@chan-j-d chan-j-d merged commit 3cf77b4 into reposense:master Aug 2, 2023
9 of 10 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chan-j-d chan-j-d chan-j-d approved these changes

@ckcherry23 ckcherry23 ckcherry23 approved these changes

@gok99 gok99 Awaiting requested review from gok99

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increasing Cypress Timeout Configuration
4 participants
@germainelee02 @ckcherry23 @zhoukerrr @chan-j-d