Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1931] Update frontend integration tests for summary and zoom view #2015

Merged
merged 16 commits into from
Aug 31, 2023

Conversation

germainelee02
Copy link
Contributor

@germainelee02 germainelee02 commented Jul 2, 2023

Fixes #1931

On the frontend, changes in the summary panel affect the zoom 
panel. However, this functionality is not well tested in our current 
Cypress tests.

Let's add additional Cypress tests for the changing of zoom and date 
range.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2023

The following links are for previewing this pull request:

@germainelee02 germainelee02 reopened this Jul 2, 2023
@ckcherry23 ckcherry23 requested a review from a team July 9, 2023 15:11
Copy link
Contributor

@vvidday vvidday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this up @germainelee02 and apologies for the late response.

I understand that the nature of these tests might make it necessary to make certain assumptions about the data in the report which might result in some hardcoding of the test actions/values.

Would it be possible to indicate whenever there's an assumption regarding the data in the comments like this? Since the tests that rely on assumptions/hardcoded data might fail in the future if the test repo gets more commits, and it would be easier for future maintainers to know exactly what assumptions are being made in the tests.

Copy link
Contributor

@vvidday vvidday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ckcherry23
ckcherry23 previously approved these changes Jul 24, 2023
Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on abstracting out common functionalities and the test coverage is also good.

Would it be possible to add test cases for some more functionalities?

  • setting the 'granularity' changes the zoom view
  • setting the 'granularity' again results in a different zoom view
  • filtering by a certain file type changes the zoom view
  • filtering by a different file type results in a different zoom view

@germainelee02
Copy link
Contributor Author

germainelee02 commented Jul 27, 2023

Nice work on abstracting out common functionalities and the test coverage is also good.

Would it be possible to add test cases for some more functionalities?

  • setting the 'granularity' changes the zoom view
  • setting the 'granularity' again results in a different zoom view
  • filtering by a certain file type changes the zoom view
  • filtering by a different file type results in a different zoom view

Should I make a separate PR for that then? @ckcherry23

@ckcherry23
Copy link
Member

Should I make a separate PR for that then? @ckcherry23

@nseah21 I think this can be done in the same PR, as they have the same purpose of testing whether changes in the summary panel are reflected in the zoom panel.

@github-actions
Copy link
Contributor

Hi,
We are going to mark this PR as stale because it has been inactive for the past 30 days.
If no further activity occurs within the following 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 7 days and leave a comment to remove the stale label.
Do let us know if you are stuck so that we can help you!'

@github-actions github-actions bot added the Stale label Aug 27, 2023
Copy link
Member

@ckcherry23 ckcherry23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@germainelee02 I will approve this for now, and add a new issue for the suggested test cases.
Please take up that issue if you would like.

@ckcherry23 ckcherry23 removed the Stale label Aug 29, 2023
@chan-j-d chan-j-d merged commit 3bad16b into reposense:master Aug 31, 2023
10 checks passed
@github-actions
Copy link
Contributor

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update frontend integration tests for summary and zoom view
4 participants