[#1968] Incorrect dropdown box for config in UG: Customizing Report #2009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvidday
requested changes
Jun 25, 2023
There was a problem hiding this comment.
Thanks for your work on this @germainelee02!
Also have a minor comment on the commit message - we usually use Let's ... for the changes being done in the PR, and use an imperative mood instead of past tense. Also, it would be good to include a short statement on "why it needs to change" (even though it's quite obvious in this case).
More info under 'commit message body'
Something like the following (feel free to change as you see fit!):
There is a bug in the UG where the assets syntax is incorrectly
displayed under the config section instead of the correct config
syntax. This could potentially confuse users.
Let's fix the bug by displaying the correct config syntax, and add a
link to the page that explains the format of config files, for user
convenience.
|
The following links are for previewing this pull request:
|
|
The following links are for previewing this pull request:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1968
https://docs-1950-pr-reposense-reposense.surge.sh/ug/customizingReports.html#customize-using-csv-config-files