Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1427] Fix non-rendering PlantUML diagram #2005

Merged
merged 6 commits into from
May 21, 2023

Conversation

yhtMinceraft1010X
Copy link
Contributor

@yhtMinceraft1010X yhtMinceraft1010X commented May 12, 2023

Fixes #1427

Proposed commit message

The Report Architecture image cannot be rendered automatically from the
puml due to Graphviz not being installed during the CI process.

Let's add the step to install Graphviz in the integration and GitHub
pages workflow.

By rendering the puml directly, this eliminates the need to manually
convert the puml to a png image.

Other information

The Report Architecture image cannot be rendered automatically from
the puml due to Graphviz not being installed during the CI process.

Let's add the step to install Graphviz in the integration and GitHub
pages workflow.

By rendering the puml directly, this eliminates the need to manually
convert the puml to a png image.
This reverts commit f24ab24.
@yhtMinceraft1010X yhtMinceraft1010X requested a review from a team May 12, 2023 17:03
Copy link
Member

@MarcusTXK MarcusTXK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job

@MarcusTXK MarcusTXK requested a review from a team May 12, 2023 17:15
@HCY123902 HCY123902 requested a review from a team May 13, 2023 02:48
@dcshzj dcshzj merged commit 3878389 into reposense:master May 21, 2023
10 checks passed
@github-actions
Copy link
Contributor

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some PlantUML diagrams will not render in deployed RepoSense website
5 participants