Make it PHP 8.2 compatible #660
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 835c2d9.
Co-authored-by: Marcin Michalski <[email protected]>
Co-authored-by: Marcin Michalski <[email protected]>
Co-authored-by: Marcin Michalski <[email protected]>
Added an extra wrapper method around the commands for createAdvisoriesDatabaseRepo these failed with the default set-up and I couldn't figure out why. One of the commands failed with a non-zero exit code, thus the others failing to. This ensures the commands always gets properly executed and otherwise an exception with extra information is thrown
Co-authored-by: Marcin Michalski <[email protected]>
Co-authored-by: Marcin Michalski <[email protected]>
Merged
|
Small note, I disabled the repman.io proxy as this seems to be very outdated. |
|
|
94noni
reviewed
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch, branched off from #580. It's that + PHP 8.0 to PHP 8.2 compatibility fixes and updates