Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove docs of removed components, simplify readd() example #849

Closed
wants to merge 1 commit into from

Conversation

lajbel
Copy link
Contributor

@lajbel lajbel commented Apr 18, 2024

  • Remove mention to children() and solid() components
  • Simplify the readd() example

@lajbel lajbel requested a review from slmjkdbtl April 18, 2024 11:17
* children(label),
* ])
*
* add(label);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this part is to have an example text with background which is made possible

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean? You want to change the example to be something like

const label = make([
    text("hi")
])

const background = add([
    rect(50, 50)
])

background.add(label)

Copy link
Contributor Author

@lajbel lajbel Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any update @slmjkdbtl ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah something like

const label = make([
    text("hi")
])

const background = add([
    rect(label.width, label.height)
])

background.add(label)

which might be a more practical example

@lajbel lajbel requested a review from slmjkdbtl April 26, 2024 10:29
@lajbel lajbel closed this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants