Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added FileName in chunk for Related Notes. #241

Merged
merged 1 commit into from
May 8, 2024
Merged

Added FileName in chunk for Related Notes. #241

merged 1 commit into from
May 8, 2024

Conversation

milaiwi
Copy link
Collaborator

@milaiwi milaiwi commented May 6, 2024

image

Added Filename of chunk that appears in Related Notes. #189

samlhuillier
samlhuillier requested changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@samlhuillier samlhuillier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! I have a couple of minor suggestions:

  1. The filename should go first, before similarity and date modified
  2. It shouldn't say "File:" before the file name

But thank you for putting this together. I think it'll add a lot of value in navigation

@milaiwi
Copy link
Collaborator Author

milaiwi commented May 6, 2024 •
edited

Let me know if you want any more changes!

image

image

samlhuillier
samlhuillier approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@samlhuillier samlhuillier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@samlhuillier samlhuillier merged commit 794d21f into reorproject:main May 8, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlhuillier samlhuillier samlhuillier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@milaiwi @samlhuillier