Tweak display_menu #5513
Merged
Tweak display_menu #5513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actually, arbitrary kwargs are a very bad thing to pass since as long as the specified screen exists (so, unless something is very wrong), they are just ignored the scope's default value change is benign as long as we don't do stupid things with it and continue to call dict() on it - and it prevents stupid things we might do to it in the future to go unseen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes no change to the API.
Fixes the bug aspect of #5509 regarding kwargs.
About the change of parameter default, look at line 1276 and the commit comments. The goal is to avoid mutable parameter defaults, which are a bad practice.