-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(self-hosted): convert experimental env vars to config options #29154
base: main
Are you sure you want to change the base?
feat(self-hosted): convert experimental env vars to config options #29154
Conversation
@@ -79,21 +79,22 @@ export async function getConfig(env: NodeJS.ProcessEnv): Promise<AllConfig> { | |||
logger.debug('No config file found on disk - skipping'); | |||
} | |||
|
|||
await deleteNonDefaultConfig(env); // Try deletion only if RENOVATE_CONFIG_FILE is specified | |||
await deleteNonDefaultConfig(env, !!config.deleteConfigFile); // Try deletion only if RENOVATE_CONFIG_FILE is specified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a problem. We can't set RENOVATE_DELETE_CONFIG_FILE
from env, because we don't pass it to the file getConfig
. so the config value isn't yet available and causes a breaking change.
also cli flags are not yet available, so wer probably need to move the delete code to a later stage.
@rarkins WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nabeelsaabna can we move this to a later stage and still achieve the goal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, we could move it to the config/parse/index
file, after we have parsed the env vars and cli flags and combined the config.
Verified each migration locally, by either logging the values of each option at runtime or confirming that they are working as expected |
globalOnly: true, | ||
}, | ||
{ | ||
name: 'eagerGlobalExtends', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name: 'eagerGlobalExtends', | |
name: 'globalExtendsEager', |
Let's rename it so that it sorts next to globalExtends
Changes
RENOVATE_X_DELETE_CONFIG_FILE
deleteConfigFile
RENOVATE_X_EAGER_GLOBAL_EXTENDS
eagerGlobalExtends
RENOVATE_X_IGNORE_NODE_WARN
ignoreNodeWarn
RENOVATE_X_S3_ENDPOINT
s3Endpoint
RENOVATE_X_S3_PATH_STYLE
s3PathStyle
There are some boolean types here. They have not been converted to
experimentalFlags
becauseGlobalConfig
hasn't been initialized yet, when they are used.Context
Last of: #27879 (comment)
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: