Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace bufio-based data reader with a state machine. #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Replace bufio-based data reader with a state machine. #9

wants to merge 3 commits into from

Commits on Sep 6, 2018

  1. Run gofmt.

    @fluffle
    fluffle committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    569e814 View commit details
    Browse the repository at this point in the history

  2. Replace bufio-based data reader with a state machine. 

    This state machine guarantees that at most one Read will be issued to
the underlying reader for every internalDataReader Read call. Preserving
these semantics stops internalDataReader from blocking when the provided
read buffer is larger than the amount of data available to read from the
underlying reader.
    @fluffle
    fluffle committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    330ec0b View commit details
    Browse the repository at this point in the history

  3. Modify code to use bufio and io.Copy where appropriate.

    @fluffle
    fluffle committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    514a30b View commit details
    Browse the repository at this point in the history