Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF-2787] add_hooks supports Var-wrapped hooks #3248

Merged
merged 3 commits into from May 15, 2024
Merged

[REF-2787] add_hooks supports Var-wrapped hooks #3248

merged 3 commits into from May 15, 2024

Conversation

masenf
Copy link
Collaborator

@masenf masenf commented May 7, 2024

  • Fix VarData definition in .pyi file to allow removal of type ignore comments
  • Var.create and Var.create_safe accept _var_data parameter
  • Replace instances where a set of imports was being passed to VarData
  • Update code throughout reduce use of ._replace to add VarData

@masenf
[REF-2787] add_hooks supports Var-wrapped hooks
aa8f3c7 
* Fix VarData definition in .pyi file to allow removal of type ignore comments
* Var.create and Var.create_safe accept _var_data parameter
* Replace instances where a set of imports was being passed to VarData
* Update code throughout reduce use of `._replace` to add VarData
@linear Linear
Copy link

linear bot commented May 7, 2024

REF-2787 add_hook ignore import from _var_data if returning hook as Var

Lendemor
Lendemor previously approved these changes May 15, 2024
View reviewed changes
@masenf masenf merged commit c5f32db into main May 15, 2024
47 checks passed
@masenf masenf deleted the masenf/add-hooks-var-data branch May 15, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lendemor Lendemor Lendemor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@masenf @Lendemor