Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shorten wiki #41

Merged
merged 7 commits into from Sep 12, 2023
Merged

Add shorten wiki #41

merged 7 commits into from Sep 12, 2023

Conversation

Katsute
Copy link
Contributor

@Katsute Katsute commented Aug 21, 2023

Closes #40

@Katsute Katsute marked this pull request as ready for review August 21, 2023 01:35
@Katsute
Copy link
Contributor Author

Katsute commented Aug 21, 2023

I'm not sure why the linter is failing, fails on main as well

@fregante
Copy link
Member

Thank you! The linter is failing due to a bug, it needs to be updated in a separate PR to at least 0.55 or 0.45.1 if I remember correctly

@Katsute Katsute marked this pull request as draft August 21, 2023 22:03
@fregante
Copy link
Member

You can run npx xo --fix

@Katsute Katsute marked this pull request as ready for review August 21, 2023 22:13
@Katsute
Copy link
Contributor Author

Katsute commented Aug 21, 2023

Fixed 🎉

fregante
fregante approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@fregante fregante left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'm hoping to hear from other reviewers. Does this format make sense? I'm thinking maybe:

Wiki: title blah blah (repo)

@fregante
Copy link
Member

Can you change the format to the suggested one?

@fregante fregante merged commit 083517d into refined-github:main Sep 12, 2023
3 checks passed
@Katsute Katsute deleted the wiki branch September 12, 2023 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fregante fregante Awaiting requested review from fregante

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shorten wiki links
2 participants
@Katsute @fregante