Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collect-commit-comments - Show all commit comments in the comment section #7349

Closed

Conversation

Leguan16
Copy link

@Leguan16 Leguan16 commented May 7, 2024

Notes

This is my first time doing this kind of stuff and I am sure there is a lot of improvements to make.
I don't think there is an easy way to replicate comments, so I had to create them manually. This is also the reason why it misses several features. The reason why I want to add such a feature is because it's hard to find comments on large commits (See test url). I would like to get feedback about the general idea and maybe some people can give me tips on how to improve things :)

Test URLs

PaperMC/DataConverter@3138743#comments

Screenshot

Before

image

After

image

@fregante
Copy link
Member

fregante commented May 8, 2024

Interesting feature but we never try to recreate large pieces of UI in Refined GitHub, we just focus on small improvements. Here each comment DOM is missing a lot of features

@fregante fregante closed this May 8, 2024
@Leguan16
Copy link
Author

Leguan16 commented May 8, 2024

Yeah, I agree it's not ideal but it's the best we can do with what github gives us to work with. It's just annoying to find comments in large commits, so i hope they add such feature to the official website. Thanks for the feedback :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants