New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add action-pr-link
feature
#6694
Conversation
When the action is defined as check run, I think this is GitHub API's bug. The |
I don't understand why can you not the the pr number from the issue title? |
@yakov116 That is not the PR number, The WorkflowRun Number |
Aha, use api v3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
I found the pull_request field works correctly only on administrator of repository regardless v4 or v3. |
As mentioned before, I don’t think this feature should use the API, but just the observer to alter the links adding |
linkify-action
which provides a link back to the PRaction-pr-link
feature
Yes I'm working with not using api call :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
One limitation I found is that GitHub does not support issues, not via pr=
nor via issue=
For example this workflow runs on both, but only the PRs can be linkified: https://github.com/refined-github/refined-github/actions/workflows/labeler.yml
Co-authored-by: Federico Brigante <[email protected]>
😢 But It is awesome that we can implement this feature without calling API. |
Description
Test URLs
Screenshot