Meta: Ensure new or edited features have Test URLs #6653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
changed the title
fregante
commented
May 15, 2023
| echo | ||
| echo VERIFICATION FAILED, "Test URLs" MISSING | ||
| exit $EXIT_CODE | ||
| fi |
|
|
||
| # Replace line breaks with "%0A" | ||
| # https://github.com/actions/toolkit/issues/193#issuecomment-605394935 | ||
| ANNOTATION=${ANNOTATION//$'\n'/%0A} |
yakov116
reviewed
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of our features lack test URLs.
There's no chance of adding them all, but we can try to by reminding ourselves to add them every time we create and change (and therefore test) a feature.
This will help us progressively add more test URLs