Lint

source/feature-manager.tsx

@@ -10,7 +10,6 @@ import onAbort from './helpers/abort-controller';
 import ArrayMap from './helpers/map-of-arrays';
 import bisectFeatures from './helpers/bisect';
 import {shouldFeatureRun} from './github-helpers';
-import polyfillTurboEvents from './github-helpers/turbo-events-polyfill';
 import optionsStorage, {RGHOptions} from './options-storage';
 import {
  applyStyleHotfixes,
@@ -151,8 +150,6 @@ const globalReady = new Promise<RGHOptions>(async resolve => {
  features.log.error = () => {/* No logging */};
  }
 
- polyfillTurboEvents();
-
  resolve(options);
 });
 

source/features/link-to-github-io.tsx

@@ -38,12 +38,12 @@ function initRepoList(signal: AbortSignal): void {
 }
 
 void features.add(import.meta.url, {
- include: [
- pageDetect.hasRepoHeader,
- ],
  asLongAs: [
  () => /\.github\.(io|com)$/.test(getRepo()?.name ?? 'shush eslint'),
  ],
+ include: [
+ pageDetect.hasRepoHeader,
+ ],
  init: initRepo,
 }, {
  include: [

source/features/linkify-user-labels.tsx

@@ -26,12 +26,12 @@ function init(signal: AbortSignal): void {
 }
 
 void features.add(import.meta.url, {
- include: [
- pageDetect.hasComments,
- ],
  asLongAs: [
  pageDetect.isRepo,
  ],
+ include: [
+ pageDetect.hasComments,
+ ],
  init,
 });
 

source/features/sync-pr-commit-title.tsx

@@ -61,7 +61,7 @@
 
  // Remove PR number from commit title
  const prTitle = getCommitTitleField()!.value
  .replace(regexJoin(/\s*\(/, '#' + getConversationNumber()!, /\)$/), '');
 
  // Fill and submit title-change form
  select(prTitleFieldSelector)!.value = prTitle;
@@ -89,12 +89,12 @@
 }
 
 void features.add(import.meta.url, {
- include: [
- pageDetect.isPRConversation,
- ],
  asLongAs: [
  userCanLikelyMergePR,
  ],
+ include: [
+ pageDetect.isPRConversation,
+ ],
  awaitDomReady: true, // DOM-based filters, feature appears at the end of the page
  init,
 });

source/github-helpers/index.test.ts

@@ -9,7 +9,7 @@ import {
 } from '.';
 
 test('getConversationNumber', () => {
- const pairs = new Map<string, string | undefined>([
+ const pairs = new Map<string, number | undefined>([
  [
  'https://github.com',
  undefined,
@@ -48,23 +48,23 @@ test('getConversationNumber', () => {
  ],
  [
  'https://github.com/refined-github/refined-github/pull/148/commits/0019603b83bd97c2f7ef240969f49e6126c5ec85',
- '148',
+ 148,
  ],
  [
  'https://github.com/refined-github/refined-github/pull/148/commits/00196',
- '148',
+ 148,
  ],
  [
  'https://github.com/refined-github/refined-github/pull/148/commits',
- '148',
+ 148,
  ],
  [
  'https://github.com/refined-github/refined-github/pull/148',
- '148',
+ 148,
  ],
  [
  'https://github.com/refined-github/refined-github/issues/146',
- '146',
+ 146,
  ],
  [
  'https://github.com/refined-github/refined-github/issues',

source/github-helpers/index.ts

@@ -9,9 +9,9 @@ import * as pageDetect from 'github-url-detection';
 export const getUsername = onetime(pageDetect.utils.getUsername);
 export const {getRepositoryInfo: getRepo, getCleanPathname} = pageDetect.utils;
 
-export const getConversationNumber = (): string | undefined => {
+export const getConversationNumber = (): number | undefined => {
  if (pageDetect.isPR() || pageDetect.isIssue()) {
- return location.pathname.split('/')[4];
+ return Number(location.pathname.split('/')[4]);
  }
 
  return undefined;

source/globals.d.ts

@@ -80,3 +80,7 @@ declare module 'react' {
 interface Node extends EventTarget {
  cloneNode(deep?: boolean): this;
 }
+
+interface SignalAsOptions {
+ signal?: AbortSignal;
+}

source/helpers/selector-observer.tsx

@@ -6,8 +6,10 @@ import {ParseSelector} from 'typed-query-selector/parser';
 import getCallerID from './caller-id';
 import isDevelopmentVersion from './is-development-version';
 
+type ObserverListener<Selector extends string> = (element: ParseSelector<Selector, HTMLElement>, options: SignalAsOptions) => void;
+
 const animation = 'rgh-selector-observer';
-const getListener = <ExpectedElement extends HTMLElement>(seenMark: string, selector: string, callback: (element: ExpectedElement) => void) => function (event: AnimationEvent) {
+const getListener = <ExpectedElement extends HTMLElement>(seenMark: string, selector: string, callback: ObserverListener<string>, signal?: AbortSignal) => function (event: AnimationEvent) {
  const target = event.target as ExpectedElement;
  // The target can match a selector even if the animation actually happened on a ::before pseudo-element, so it needs an explicit exclusion here
  if (target.classList.contains(seenMark) || !target.matches(selector)) {
@@ -17,7 +19,7 @@ const getListener = <ExpectedElement extends HTMLElement>(seenMark: string, sele
  // Removes this specific selector’s animation once it was seen
  target.classList.add(seenMark);
 
- callback(target);
+ callback(target, {signal});
 };
 
 const registerAnimation = onetime((): void => {
@@ -28,8 +30,8 @@ export default function observe<
  Selector extends string,
 >(
  selectors: Selector | readonly Selector[],
- listener: (element: ParseSelector<Selector, HTMLElement>) => void,
- {signal}: {signal?: AbortSignal} = {},
+ listener: ObserverListener<Selector>,
+ {signal}: SignalAsOptions = {},
 ): void {
  if (signal?.aborted) {
  return;
@@ -55,5 +57,5 @@ export default function observe<
  signal?.addEventListener('abort', () => {
  rule.remove();
  });
- window.addEventListener('animationstart', getListener(seenMark, selector, listener), {signal});
+ window.addEventListener('animationstart', getListener(seenMark, selector, listener, signal), {signal});
 }