Add releases-dropdown feature
#6506
Conversation
|
Ready. Readme screenshot:
Screen.Recording.mov |
source/features/tags-dropdown.tsx
Outdated
|
|
||
| void features.add(import.meta.url, { | ||
| include: [ | ||
| pageDetect.isReleasesOrTags, |
There was a problem hiding this comment.
There was a problem hiding this comment.
Then this should use isReleases? Because the search box only exists there
Also previous tags-dropdown works on tags page, should this one?
There was a problem hiding this comment.
Then this should use isReleases? Because the search box only exists there
Done
Also previous tags-dropdown works on tags page, should this one?
The issue is that the native field SEARCHES the releases notes, which means it does nothing on tags. See https://github.com/python/cpython/releases?q=v3&expanded=true which is empty even if there are plenty "v3" tags
So if we were to add this feature there, we'd have to reinvent the feature to not use datalist. Not worth it in this PR (or maybe ever)
source/features/tags-dropdown.tsx
Outdated
| {latestTags.reverse().map(tag => <option value={tag}/>)} | ||
| </datalist>, | ||
| ); | ||
| searchField.setAttribute('list', 'rgh-tags-dropdown'); |
There was a problem hiding this comment.
Unreal… searchField.list is read-only 🤷♂️
source/features/tags-dropdown.tsx
Outdated
| const field = event.delegateTarget; | ||
| const selectedTag = field.value; | ||
| if (!('inputType' in event) && latestTags!.includes(selectedTag)) { | ||
| location.href = buildRepoURL('releases/tag', selectedTag); |
There was a problem hiding this comment.
As expected, it's broken on unescaped tag names:
https://github.com/refined-github/refined-github/releases
There was a problem hiding this comment.
Fixed! Pretty sure we have the same bug in features like tags-on-commits-list too
There was a problem hiding this comment.
All good:
Also cool UI:
|
The search icon and dropdown arrow is unaligned. Can't unsee. Let's add these CSS: /* This can go into github-bugs */
.subnav-search-icon {
top: 8px;
}
#release-filter::-webkit-calendar-picker-indicator {
position: relative;
top: -2px;
}
|
|
Added both to
|
Follows:
tags-dropdownis broken #6257tags-dropdownfeature #6438Super easy, barely an inconvenience. The only issue is that it's technically misusing the
datalistfor navigation (just like mobile websites have done withselectfrom 2007 until recently)Test URLs
https://github.com/refined-github/refined-github/releases
Screenshot