Refactor tab-size to reduce conflicts
#6480
Conversation
fregante
changed the title
tab-size to reduce conflicts
|
I hope to merge this by tomorrow so that I can release 23.4.10 |
Co-authored-by: Federico Brigante <[email protected]>
There was a problem hiding this comment.
I think we're good now, there was an issue with the inconsistency between --tab-size and tab-size in some situations, so I think this should make sure it doesn't happen anymore.
* {tab-size: var(--tab-size)} would probably be the only way to ensure this, but I don’t think it's necessary.
Note
GitHub currently has a bug where the first tab in code embeds is trimmed. This is unrelated to RG (see the tabs below)
| :root, | ||
| .tab-size[data-tab-size='8'] { | ||
| --tab-size: 4; | ||
| tab-size: var(--tab-size); | ||
| } |
There was a problem hiding this comment.
The tab-size feature overrides the tab size. This one single selector overrides it. I think this is the most consistent situation we got so far
There was a problem hiding this comment.
Sorry if my changes have confused you 😢
Could have just reverted eb6f729 (#6480) if you feel the former version is better
Now this selector isn't specific enough (lacking .comment-body) 🤔
I opened a new pull request to fix this
There was a problem hiding this comment.
Heh you're right I didn't even notice that I just undid your commit 😅
There was a problem hiding this comment.
It's fine, I guess I'm just bad at expressing my intent (and tend to complicate things) 😂
|
phew finally 😅 |
| [data-tab-size='7'] { | ||
| --tab-size: 7; | ||
| } |
There was a problem hiding this comment.
Does this appear anywhere? Preferences only have 9 options: 1-6, 8, 10, 12. Not all 12 steps are available.
There was a problem hiding this comment.
You're right, this was more like (unnecessary) future-proofing 😂
There was a problem hiding this comment.
I will add this to lint (to-do)
These does not exist in GitHub preferences #6480 (comment)
Fix #6461
Fix #6477
Test URLs
tab-sizesandbox#19Unaffected URLs
Screenshot